This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
adding RFC doc and linking in README #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-zh
approved these changes
Jun 16, 2020
|
Np but a suggestion: committing to dev branch in main repository directly might not a good practice of open source development, try to fork the repository to your own hub and make code changes in branches your own repository aka ps48/kibana-notebooks and create pull requests from corresponding branches. |
chloe-zh
reviewed
Jun 17, 2020
|
LGTM! |
chloe-zh
approved these changes
Jun 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
adding RFC doc with images and linking it in README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.