This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
More polish to visual report(pdf and png) #211
Merged
zhongnansu
merged 5 commits into
opendistro-for-elasticsearch:dev
from
zhongnansu:removee-poller
Nov 24, 2020
Merged
More polish to visual report(pdf and png) #211
zhongnansu
merged 5 commits into
opendistro-for-elasticsearch:dev
from
zhongnansu:removee-poller
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgcreative
reviewed
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the comment re: page title.
davidcui1225
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kevin Garcia <hello@kevingarcia.me>
joshuali925
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 4, 2020
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 7, 2020
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 8, 2020
@zhongnansu please see #350 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.