Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

More polish to visual report(pdf and png) #211

Merged

Conversation

zhongnansu
Copy link
Member

Issue #, if available:

Description of changes:

  • remove all buttons
  • change the setContent to use template with more css stylesheet
  • TODO: the text in pdf is still not selectable, will probably add in the next phase as enhancement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@kgcreative kgcreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the comment re: page title.

kibana-reports/server/routes/utils/report_template.html Outdated Show resolved Hide resolved
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Kevin Garcia <hello@kevingarcia.me>
Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongnansu zhongnansu merged commit 4c3be6a into opendistro-for-elasticsearch:dev Nov 24, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 4, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 7, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 8, 2020
@iget-master
Copy link

@zhongnansu please see #350

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants