This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Added Loading Modal to Details pages #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
joshuali925,
akbhatta,
zhongnansu and
abbashus
akbhatta
approved these changes
Nov 25, 2020
joshuali925
approved these changes
Nov 25, 2020
zhongnansu
reviewed
Nov 25, 2020
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| export { GenerateReportLoadingModal } from './loading_modal'; |
There was a problem hiding this comment.
why need this, you already export this from loading_modal.tsx
There was a problem hiding this comment.
So when we export it in other files we don't need to write import from '../../loading_modal/loading_modal, eliminates need for nested import
There was a problem hiding this comment.
I think loading_modal is like a util components, which may better be placed under utils for other components to call. Otherwise, if you write a index.ts for every small component, the project will have too many files. Just my 2 cents, may refer to some project structure standard later when we do the refactor
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 4, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 7, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 8, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Extract
GenerateReportLoadingModaland added it toReport detailsandReport definition detailsfor file format download.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.