Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

[Bug fix] Use default max size to call getAll ES API #224

Merged
merged 5 commits into from
Nov 26, 2020

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Nov 25, 2020

Issue #, if available:

The default query size in ES side is set to 100, should pass in parameter if we want to retrieve more data

Description of changes:

  • From Kibana side, add fromIndex and maxItems as optional params, and use default value 10000 for maxItems.
  • Test with 10000 report instances added. Browser response time is within 4 secs. It's tolerable for the initial release.
  • TODO: need to implement pagination in the EUI, currently the table eui component is EuiInMemoryTable, which requires all possible data to be loaded. Need to consider use low level components such as EuiBasicTable along with EuiPagination, EuiSearchBar

Others

  • set enabled field to be true when switching from on-demand to scheduled report definition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhongnansu zhongnansu marked this pull request as ready for review November 26, 2020 00:02
Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongnansu zhongnansu merged commit dce1116 into opendistro-for-elasticsearch:dev Nov 26, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 4, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants