Headless chrome creation script and readme file #229
Conversation
|
any idea why the github action fails?If a re-run will fix the issue, could you add a step retry? @joshuali925 @harold-wang |
because #228 is not merged, it will update chromium download url |
| # How to call in Command line: | ||
| >> please use what you used for testing this << replace me >> |
There was a problem hiding this comment.
what's the purpose of these two lines?
There was a problem hiding this comment.
this was a review comment/ @harold-wang can you pls update here. thanks
There was a problem hiding this comment.
what's the purpose of these two lines?
Josh, these are command used to verify chrome in command line.
MAC/Linux PNG : ./headless_shell --headless --disable-gpu --screenshot=test.png https://www.google.com
MAC/Linux PDF: ./headless_shell --headless --disable-gpu --print-to-pdf=test.png https://www.google.com
| libnss3-dev | ||
| fonts-liberation | ||
| libfontconfig | ||
| (installation command example : sudo apt update && apt install libnss3-dev fonts-liberation libfontconfig) |
There was a problem hiding this comment.
These dependencies are for Ubuntu, for CentOS I had to install a lot more
sudo yum install -y libnss3.so xorg-x11-fonts-100dpi xorg-x11-fonts-75dpi xorg-x11-utils xorg-x11-fonts-cyrillic xorg-x11-fonts-Type1 xorg-x11-fonts-misc fontconfig freetype
I listed them in this PR #222, could you update it here?
There was a problem hiding this comment.
Add test command to verify chrome in linux:
MAC/Linux PNG : ./headless_shell --headless --disable-gpu --screenshot=test.png https://www.google.com
MAC/Linux PDF: ./headless_shell --headless --disable-gpu --print-to-pdf=test.png https://www.google.com
| # How to call in Command line: | ||
| >> please use what you used for testing this << replace me >> |
There was a problem hiding this comment.
what's the purpose of these two lines?
Josh, these are command used to verify chrome in command line.
MAC/Linux PNG : ./headless_shell --headless --disable-gpu --screenshot=test.png https://www.google.com
MAC/Linux PDF: ./headless_shell --headless --disable-gpu --print-to-pdf=test.png https://www.google.com
Np: can we use the domain we owned such as opendistro website, instead of google.com |
|
…icsearch#229) * Headless chrome creation script and readme file * Rename README_chrome_headless.md to README.md * Add README.md * add comments on how to run chrome to get pdf and png report * Change test web from google.com to https://opendistro.github.io/for-elasticsearch
…icsearch#229) * Headless chrome creation script and readme file * Rename README_chrome_headless.md to README.md * Add README.md * add comments on how to run chrome to get pdf and png report * Change test web from google.com to https://opendistro.github.io/for-elasticsearch
Issue #, if available:
Description of changes:
We added script and readme file to generate the headless chrome for puppeteer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.