Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Bug Fixes in UI #241

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Bug Fixes in UI #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kibana-reports/public/components/context_menu/context_menu_ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const popoverMenu = () => {
<span class="euiContextMenuItem__text" style="padding-left: 10px; padding-right: 10px; margin-top: 10px; box-decoration-break: clone; display: inline-block;">
Files can take a minute or two
to generate depending on the
size of your dashboard
size of your source data
</span>
</div>
<div>
Expand Down
4 changes: 2 additions & 2 deletions ...na-reports/public/components/main/report_definition_details/report_definition_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,10 +336,10 @@ export function ReportDefinitionDetails(props) {
// TODO: need better display
timePeriod: moment.duration(timeDuration).humanize(),
fileFormat: reportFormat,
reportHeader: reportParams.core_params.hasOwnProperty('header')
reportHeader: reportParams.core_params.hasOwnProperty('header') && reportParams.core_params.header != ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note it's better to use !== in general so no implicit conversion is done, although in this case it doesn't seem to matter

? converter.makeMarkdown(reportParams.core_params.header)
: `\u2014`,
reportFooter: reportParams.core_params.hasOwnProperty('footer')
reportFooter: reportParams.core_params.hasOwnProperty('footer') && reportParams.core_params.footer != ""
? converter.makeMarkdown(reportParams.core_params.footer)
: `\u2014`,
triggerType: triggerType,
Expand Down
24 changes: 20 additions & 4 deletions ...ublic/components/main/report_details/__tests__/__snapshots__/report_details.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,11 @@ exports[`<ReportDetails /> panel render 5 hours recurring component 1`] = `
</dt>
<dd
class="euiDescriptionList__description"
/>
>
<p>
—
</p>
</dd>
</dl>
</div>
<div
Expand All @@ -264,7 +268,11 @@ exports[`<ReportDetails /> panel render 5 hours recurring component 1`] = `
</dt>
<dd
class="euiDescriptionList__description"
/>
>
<p>
—
</p>
</dd>
</dl>
</div>
<div
Expand Down Expand Up @@ -636,7 +644,11 @@ exports[`<ReportDetails /> panel render on-demand component 1`] = `
</dt>
<dd
class="euiDescriptionList__description"
/>
>
<p>
—
</p>
</dd>
</dl>
</div>
<div
Expand All @@ -652,7 +664,11 @@ exports[`<ReportDetails /> panel render on-demand component 1`] = `
</dt>
<dd
class="euiDescriptionList__description"
/>
>
<p>
—
</p>
</dd>
</dl>
</div>
<div
Expand Down
4 changes: 2 additions & 2 deletions kibana-reports/public/components/main/report_details/report_details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,10 @@ export function ReportDetails(props) {
time_period: parseTimePeriod(queryUrl),
defaultFileFormat: coreParams.report_format,
state: state,
reportHeader: reportParams.core_params.hasOwnProperty('header')
reportHeader: reportParams.core_params.hasOwnProperty('header') && reportParams.core_params.header != ""
? converter.makeMarkdown(reportParams.core_params.header)
: `\u2014`,
reportFooter: reportParams.core_params.hasOwnProperty('footer')
reportFooter: reportParams.core_params.hasOwnProperty('footer') && reportParams.core_params.footer != ""
? converter.makeMarkdown(reportParams.core_params.footer)
: `\u2014`,
triggerType: triggerType,
Expand Down
2 changes: 1 addition & 1 deletion kibana-reports/public/components/report_definitions/report_trigger/report_trigger.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ export function ReportTrigger(props: ReportTriggerProps) {
error={'Invalid cron expression.'}
labelAppend={
<EuiText size="xs">
<EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/">
<EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/" target="_blank">
Cron help
</EuiLink>
</EuiText>
Expand Down