Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

add double dots to relative url in fetch() #242

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

zhongnansu
Copy link
Member

Issue #, if available:
in-context menu download fails when 'server.basepath' in kibana.yml is configured, by default it's empty string.

Description of changes:

  • Add 2 dots to use relative url, just like how we call API in other places such as create report definition, getAll reports/report definition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zhongnansu zhongnansu marked this pull request as ready for review December 4, 2020 23:47
@zhongnansu zhongnansu changed the title add double dots to fetch url add double dots to relative url in fetch() Dec 4, 2020
Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongnansu zhongnansu merged commit bb7e815 into opendistro-for-elasticsearch:dev Dec 7, 2020
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants