This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Optimize selectors for DOM operation to reduce possible version compatibility issue #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuali925
approved these changes
Dec 10, 2020
zhongnansu
added a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The current DOM element selector we use is not generic enough, so it may lead to more manual work during each version compatibility check. Some html element of Kibana dashboard with minor update will easily break the report creation logic.
Description of changes:
Instead of using a specific class/id selector of a specific element in a specific kibana version, I tried to come up with a generic selector while we operate the DOM.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.