Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Add Download Cypress Tests #253

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:

  • Added cypress tests for download actions (landing page, and PDF/PNG on context menu)
  • Renamed cypress/ to .cypress/ to prevent Kibana restart on every change
  • Added HTML ids to Reporting loading modal
  • Updated snapshots

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #253 (2dbd2bd) into dev (461cdb3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #253   +/-   ##
=======================================
  Coverage   74.75%   74.75%           
=======================================
  Files          32       32           
  Lines        1739     1739           
  Branches      340      340           
=======================================
  Hits         1300     1300           
  Misses        434      434           
  Partials        5        5           
Impacted Files Coverage Δ
...ic/components/main/loading_modal/loading_modal.tsx 75.00% <ø> (ø)
...a-reports/public/components/main/reports_table.tsx 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461cdb3...2dbd2bd. Read the comment docs.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave few comments

Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does downloading this way trigger the "select download directory" browser dialog?

@davidcui1225
Copy link
Contributor Author

does downloading this way trigger the "select download directory" browser dialog?

No, haven't seen that triggered.

@davidcui1225 davidcui1225 merged commit a59e2c3 into opendistro-for-elasticsearch:dev Dec 16, 2020
@davidcui1225 davidcui1225 deleted the download-cypress-tests branch December 16, 2020 17:26
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants