This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Definition Details Modal & Delete Toast #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
joshuali925,
akbhatta,
zhongnansu and
abbashus
Codecov Report
@@ Coverage Diff @@
## dev #258 +/- ##
==========================================
+ Coverage 74.75% 74.87% +0.11%
==========================================
Files 32 32
Lines 1739 1751 +12
Branches 340 341 +1
==========================================
+ Hits 1300 1311 +11
- Misses 434 435 +1
Partials 5 5
Continue to review full report at Codecov.
|
joshuali925
approved these changes
Dec 16, 2020
May have to add cypress tests for these changes, good call |
|
the codecov is failing, could you check? |
zhongnansu
approved these changes
Dec 17, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Added loading modal for
Generate reportbutton in on-demand Report definition details page, and successful delete toast for deleting a report definition.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.