Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Reports Table Backport Changes #261

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:

  • In-context menu reports now are named after the title of the report source instead of just On_demand report
  • Removed report definitions table
  • Removed reports table filters
  • Added report ID field with report name + uuid
  • Removed option to go to Report details page
  • Changed source field to use report name vs source type
  • Add time period field

Screen Shot 2020-12-16 at 5 37 06 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comments

@davidcui1225 davidcui1225 marked this pull request as ready for review December 17, 2020 02:00
@davidcui1225 davidcui1225 merged commit eae858e into opendistro-for-elasticsearch:7.9.1 Dec 17, 2020
@davidcui1225 davidcui1225 deleted the aes-release-ui-fixes branch December 17, 2020 02:12
@zhongnansu
Copy link
Member

zhongnansu commented Dec 17, 2020

Just found an issue, you are genrating the uuid on the fly, it changes when I refresh the report table. This name should be persistent, and saved as the report name field in the schema. @davidcui-amzn

Also could you clean the yarn.lock, by yarn kbn clean and yarn kbn bootstrap? Those uuid dependencies are still there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants