This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Fix UUID Generation #263
Merged
Fix UUID Generation #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
requested review from
joshuali925,
akbhatta,
zhongnansu and
abbashus
zhongnansu
reviewed
Dec 17, 2020
| @@ -93,7 +94,7 @@ const generateInContextReport = ( | |||
| time_to: timeRanges.time_to.valueOf(), | |||
| report_definition: { | |||
| report_params: { | |||
| report_name: $('span.euiBreadcrumb').prop('title'), | |||
| report_name: $('span.euiBreadcrumb').prop('title') + '_' + uuidv4(), | |||
There was a problem hiding this comment.
Do we have snapshot testing for in-context menu UI? Or is there a way to add?
There was a problem hiding this comment.
We can add snapshot testing- but this line 97 highlighted will not be tested even if we add in-context UI snapshots
zhongnansu
approved these changes
Dec 17, 2020
joshuali925
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.