This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Configure Max Size for Dashboards API & Minor UI Changes #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal icon to cron help link in report trigger
davidcui1225
requested review from
joshuali925,
akbhatta,
zhongnansu and
abbashus
zhongnansu
approved these changes
Dec 18, 2020
| @@ -479,7 +479,7 @@ export function ReportTrigger(props: ReportTriggerProps) { | |||
| error={'Invalid cron expression.'} | |||
| labelAppend={ | |||
| <EuiText size="xs"> | |||
| <EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/" target="_blank"> | |||
| <EuiLink href="https://opendistro.github.io/for-elasticsearch-docs/docs/alerting/cron/" target="_blank" external={true}> | |||
There was a problem hiding this comment.
what does this addition attribute do?
There was a problem hiding this comment.
Adds the external icon in the description screenshot
akbhatta
approved these changes
Dec 18, 2020
Codecov Report
@@ Coverage Diff @@
## dev #266 +/- ##
=======================================
Coverage 74.87% 74.87%
=======================================
Files 32 32
Lines 1751 1751
Branches 341 341
=======================================
Hits 1311 1311
Misses 435 435
Partials 5 5
Continue to review full report at Codecov.
|
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Dec 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#264
Description of changes:
DEFAULT_MAX_SIZEconstant which is 10000.cron helplink inReport triggerEuiSpacerin Report settings to correct spacingBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.