Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Add flag to chromium to use single process #268

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Add flag to chromium to use single process #268

merged 1 commit into from
Dec 18, 2020

Conversation

joshuali925
Copy link
Contributor

@joshuali925 joshuali925 commented Dec 18, 2020

Issue #, if available:
#265

Description of changes:

  • Add '--no-zygote', '--single-process' flags when Puppeteer launches chromium to reduce number of processes and memory usage

Did some testing on MacOS, Windows, Amazon Linux 2, Ubuntu and didn't find side effects

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #268 (ba95631) into dev (a047d10) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #268   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          32       32           
  Lines        1754     1754           
  Branches      340      340           
=======================================
  Hits         1314     1314           
  Misses        435      435           
  Partials        5        5           
Impacted Files Coverage Δ
...r/routes/utils/visual_report/visualReportHelper.ts 83.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a047d10...ba95631. Read the comment docs.

@joshuali925 joshuali925 merged commit e27146a into opendistro-for-elasticsearch:dev Dec 18, 2020
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants