Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Report Instance Integration Tests #274

Merged

Conversation

davidcui1225
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
Adding test suite for ReportInstanceRestHandler and ReportInstanceListRestHandler

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #274 (cccab4d) into dev (caa260d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #274   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          32       32           
  Lines        1754     1754           
  Branches      340      340           
=======================================
  Hits         1314     1314           
  Misses        435      435           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47b983...cccab4d. Read the comment docs.

Copy link
Contributor

@akbhatta akbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be add validation for reportInstance values?

@davidcui1225 davidcui1225 merged commit 2b1422c into opendistro-for-elasticsearch:dev Dec 22, 2020
@davidcui1225 davidcui1225 deleted the report-instance-it branch December 22, 2020 21:30
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants