This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Fixed Edit Report Definition Trigger Type Pre-fill #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #280 +/- ##
======================================
Coverage ? 74.81%
======================================
Files ? 32
Lines ? 1755
Branches ? 341
======================================
Hits ? 1313
Misses ? 437
Partials ? 5 Continue to review full report at Codecov.
|
zhongnansu
approved these changes
Dec 29, 2020
zhongnansu
pushed a commit
to zhongnansu/kibana-reports
that referenced
this pull request
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
When going to the
Edit report definitionpage for a recurring definition, report definitions that had aDailyconfiguration would always be pre-filled with an interval ofEvery 1 minute. Now, daily definitions correctly fill toDailyinReport trigger.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.