Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Support creating report for saved objects with custom id #283

Merged
merged 3 commits into from
Jan 6, 2021

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Jan 5, 2021

Issue #, if available:
#252 #250

Description of changes:

  • refactor the regex for url validation, which removes the part that validates the saved object id to be strict uuid
  • instead, add one more step to use the exists API to verify if the saved_objec_id actually exists in ES.
  • Add unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #283 (f803b9e) into dev (45abee7) will increase coverage by 0.18%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #283      +/-   ##
==========================================
+ Coverage   74.94%   75.12%   +0.18%     
==========================================
  Files          32       32              
  Lines        1764     1793      +29     
  Branches      342      347       +5     
==========================================
+ Hits         1322     1347      +25     
- Misses        437      441       +4     
  Partials        5        5              
Impacted Files Coverage Δ
kibana-reports/server/utils/validationHelper.ts 89.18% <86.66%> (-10.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45abee7...f803b9e. Read the comment docs.

@zhongnansu zhongnansu changed the title Support report for saved object with custom id Support creating report for saved objects with custom id Jan 5, 2021
@zhongnansu zhongnansu marked this pull request as ready for review January 5, 2021 23:58
@zhongnansu zhongnansu merged commit 66164c3 into opendistro-for-elasticsearch:dev Jan 6, 2021
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Jan 6, 2021
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants