Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Add Search box to Report Source Selection #286

Conversation

davidcui1225
Copy link
Contributor

@davidcui1225 davidcui1225 commented Jan 6, 2021

Issue #, if available:
#264
Description of changes:

  • Changed Report source selection in Report settings to be EuiComboBox vs. Drop-down list. Now users can search for their report sources.
  • Create report definition no longer has pre-populated report source, users will have to enter it manually
  • Added front-end input validation for Report source to verify field is not empty
  • Updated cypress test to select report source

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #286 (17df648) into dev (45abee7) will increase coverage by 2.33%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #286      +/-   ##
==========================================
+ Coverage   74.94%   77.27%   +2.33%     
==========================================
  Files          32       32              
  Lines        1764     1769       +5     
  Branches      342      348       +6     
==========================================
+ Hits         1322     1367      +45     
+ Misses        437      397      -40     
  Partials        5        5              
Impacted Files Coverage Δ
...itions/report_settings/report_settings_helpers.tsx 100.00% <ø> (+6.34%) ⬆️
...rt_definitions/report_settings/report_settings.tsx 89.32% <93.33%> (+14.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45abee7...17df648. Read the comment docs.

@davidcui1225
Copy link
Contributor Author

codecov failed- will add more tests

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything else you can do to resolve the codecov failure?

@davidcui1225
Copy link
Contributor Author

codecov failed- will add more tests

Codecov fixed- coverage raised significantly

@davidcui1225 davidcui1225 merged commit 1bf159c into opendistro-for-elasticsearch:dev Jan 6, 2021
@davidcui1225 davidcui1225 deleted the searchbox-report-source branch January 6, 2021 23:12
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Jan 6, 2021
zhongnansu pushed a commit to zhongnansu/kibana-reports that referenced this pull request Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants