Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Update timeRangeMatcher to avoid create report failure #292

Merged

Conversation

zhongnansu
Copy link
Member

Issue #, if available:

  • Fail to generate report on certain visualization items

Description of changes:

  • Root cause: the timeRangeMatcher fails on certain input urls. So the generate report API call fails to make from client to server
  • Solution: update the regex solves the issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #292 (a7ba785) into dev (1bf159c) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #292      +/-   ##
==========================================
+ Coverage   77.61%   77.62%   +0.01%     
==========================================
  Files          32       32              
  Lines        1800     1801       +1     
  Branches      356      356              
==========================================
+ Hits         1397     1398       +1     
  Misses        398      398              
  Partials        5        5              
Impacted Files Coverage Δ
.../components/main/report_details/report_details.tsx 76.08% <ø> (ø)
kibana-reports/public/components/utils/utils.tsx 75.00% <ø> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf159c...a7ba785. Read the comment docs.

Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

@anirudha anirudha merged commit 47cbe19 into opendistro-for-elasticsearch:dev Jan 8, 2021
zhongnansu added a commit to zhongnansu/kibana-reports that referenced this pull request Jan 8, 2021
zhongnansu added a commit that referenced this pull request Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants