Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

dumpcoverage for each IT #296

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Jan 8, 2021

Issue #, if available: N/A

Description of changes:

Screen Shot 2021-01-08 at 10 28 33 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #296 (9814eff) into dev (45abee7) will increase coverage by 2.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #296      +/-   ##
==========================================
+ Coverage   74.94%   77.67%   +2.72%     
==========================================
  Files          32       32              
  Lines        1764     1805      +41     
  Branches      342      356      +14     
==========================================
+ Hits         1322     1402      +80     
+ Misses        437      398      -39     
  Partials        5        5              
Impacted Files Coverage Δ
kibana-reports/server/utils/validationHelper.ts 89.18% <0.00%> (-10.82%) ⬇️
kibana-reports/public/components/main/main.tsx 59.59% <0.00%> (ø)
.../components/main/report_details/report_details.tsx 76.08% <0.00%> (ø)
...rts/server/routes/utils/savedSearchReportHelper.ts 98.78% <0.00%> (+0.03%) ⬆️
...a-reports/server/routes/utils/dataReportHelpers.ts 59.43% <0.00%> (+0.78%) ⬆️
...bana-reports/public/components/main/main_utils.tsx 76.53% <0.00%> (+3.61%) ⬆️
...itions/report_settings/report_settings_helpers.tsx 100.00% <0.00%> (+6.34%) ⬆️
kibana-reports/public/components/utils/utils.tsx 75.00% <0.00%> (+8.33%) ⬆️
...rt_definitions/report_settings/report_settings.tsx 89.32% <0.00%> (+14.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45abee7...9814eff. Read the comment docs.

@zhongnansu
Copy link
Member

Does codecov pick this jacoco report automatically? From the codecov comment of this PR, why the coverage increases significantly?

* The new internal testing framework removed some gradle tasks we were listening to,
* to choose a good time to do it. This will dump the executionData to file after each test.
* TODO: This is also currently just overwriting integTest.exec with the updated execData without
* resetting after writing each time. This can be improved to either write an exec file per test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the test coverage is getting merged.

@zhongnansu zhongnansu merged commit 837601f into opendistro-for-elasticsearch:dev Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants