Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Change release workflows to use new staging bucket for artifacts #301

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Jan 12, 2021

Issue #, if available:

Description of changes:
The infrastructure team is separating the production and staging locations into different AWS accounts. Plugins need to modify their workflows to publish to the new locations. This PR changes the CD workflow to add a build number and write the zip artifact to staging.artifacts.opendistroforelasticsearch.amazon.com.

Test Results:
https://github.com/gaiksaya/kibana-reports/runs/1746023375?check_suite_focus=true

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #301 (9cfb651) into dev (a11a63c) will decrease coverage by 13.50%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##                dev     #301       +/-   ##
=============================================
- Coverage     77.67%   64.16%   -13.51%     
- Complexity        0      291      +291     
=============================================
  Files            32      100       +68     
  Lines          1805     4044     +2239     
  Branches        356      614      +258     
=============================================
+ Hits           1402     2595     +1193     
- Misses          398     1288      +890     
- Partials          5      161      +156     
Flag Coverage Δ Complexity Δ
Kibana-reports 77.67% <ø> (?) 0.00 <ø> (?)
reports-scheduler 53.28% <ø> (?) 0.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...heduler/resthandler/ReportDefinitionRestHandler.kt 91.66% <0.00%> (ø) 8.00% <0.00%> (?%)
...sscheduler/model/GetAllReportDefinitionsRequest.kt 17.64% <0.00%> (ø) 5.00% <0.00%> (?%)
...search/reportsscheduler/action/PluginBaseAction.kt 27.65% <0.00%> (ø) 3.00% <0.00%> (?%)
...rtsscheduler/model/OnDemandReportCreateResponse.kt 33.33% <0.00%> (ø) 3.00% <0.00%> (?%)
...portsscheduler/model/GetReportDefinitionRequest.kt 18.51% <0.00%> (ø) 4.00% <0.00%> (?%)
...rch/reportsscheduler/index/ReportInstancesIndex.kt 46.45% <0.00%> (ø) 10.00% <0.00%> (?%)
...tsscheduler/scheduler/ReportDefinitionJobParser.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...rtsscheduler/action/GetAllReportInstancesAction.kt 66.66% <0.00%> (ø) 3.00% <0.00%> (?%)
...sscheduler/model/UpdateReportDefinitionResponse.kt 26.08% <0.00%> (ø) 3.00% <0.00%> (?%)
...rtsscheduler/action/InContextReportCreateAction.kt 66.66% <0.00%> (ø) 3.00% <0.00%> (?%)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a11a63c...9cfb651. Read the comment docs.

@gaiksaya gaiksaya marked this pull request as draft January 12, 2021 18:25
@gaiksaya gaiksaya marked this pull request as ready for review January 22, 2021 00:50
@gaiksaya gaiksaya changed the title [WIP] Change release workflows to use new staging bucket for artifacts Change release workflows to use new staging bucket for artifacts Jan 22, 2021
@zhongnansu zhongnansu added the build Issue and question regarding plugin build label Jan 22, 2021
@peterzhuamazon peterzhuamazon merged commit 1a5b871 into opendistro-for-elasticsearch:dev Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build Issue and question regarding plugin build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants