This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add support for ES REST API as generic commands #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VijayanB
added
odfe-cli
VijayanB
changed the title
Codecov Report
@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 64.74% 65.54% +0.79%
==========================================
Files 21 28 +7
Lines 1268 1457 +189
==========================================
+ Hits 821 955 +134
- Misses 353 404 +51
- Partials 94 98 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Added curl, get, put, post, delete commands to execute appropriate REST Action. Added integration tests.
Since elasticsearch can support output format as json/yaml, allow user to add it as argument. if no value is passed, default by elasticsearch will be returned.
curl command accept a filter_path parameter that can be used to filter the response returned by Elasticsearch. This parameter takes a comma separated list of filters.
jmazanec15
reviewed
Feb 22, 2021
commands/curl.go
Outdated
| //curlCommand is base command for Elasticsearch REST APIs. | ||
| var curlCommand = &cobra.Command{ | ||
| Use: curlCommandName, | ||
| Short: "Manage elasticsearch core features", |
There was a problem hiding this comment.
nit: Capitalize elasticsearch
commands/curl.go
Outdated
| var curlCommand = &cobra.Command{ | ||
| Use: curlCommandName, | ||
| Short: "Manage elasticsearch core features", | ||
| Long: "Use curl command to configure and access features directly", |
There was a problem hiding this comment.
rephrase: "Use the curl command to execute any REST API calls against the cluster."
| var curlPutExample = ` | ||
| # Create a knn index from mapping setting saved in file "knn-mapping.json" | ||
| odfe-cli curl put --path "my-knn-index" \ | ||
| --data "@some-location/knn-mapping.json" \ |
There was a problem hiding this comment.
Out of curiousity: is prefixing file input with @ a convention in another cli?
There was a problem hiding this comment.
Not really, usually there will be two different flags. This i borrowed from curl. Do you prefer as another flag "--data-file-path" something like that?
There was a problem hiding this comment.
If this is how curl does it, thats fine
jmazanec15
approved these changes
Feb 23, 2021
vamshin
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gateway, controller to represent any REST API and execute.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.