Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Remove custom validation #74

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

VijayanB
Copy link
Member

Use framework provided validation.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@VijayanB VijayanB added the Refactoring rewriting of computer code to improve its readability or structure without affecting feature label Mar 26, 2021
@VijayanB VijayanB self-assigned this Mar 26, 2021
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #74 (7dde9b5) into main (3e8cd56) will increase coverage by 0.67%.
The diff coverage is n/a.

❗ Current head 7dde9b5 differs from pull request most recent head 2ae6670. Consider uploading reports for the commit 2ae6670 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   64.94%   65.61%   +0.67%     
==========================================
  Files          30       30              
  Lines        1566     1550      -16     
==========================================
  Hits         1017     1017              
+ Misses        445      430      -15     
+ Partials      104      103       -1     
Flag Coverage Δ
odfe-cli 65.61% <ø> (+0.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/ad_delete.go 21.05% <ø> (+2.87%) ⬆️
commands/ad_get.go 7.50% <ø> (+0.52%) ⬆️
commands/ad_start_stop.go 20.00% <ø> (+1.81%) ⬆️
commands/ad_update.go 23.52% <ø> (+4.48%) ⬆️
commands/profile.go 53.10% <ø> (+1.07%) ⬆️

Use framework provided validation.
@VijayanB VijayanB merged commit 9a50bcf into opendistro-for-elasticsearch:main Mar 26, 2021
@VijayanB VijayanB deleted the validation branch March 26, 2021 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Refactoring rewriting of computer code to improve its readability or structure without affecting feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants