This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix performance-analyzer-agent configFilePath #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a class Util.java which we use to look up the location of the performance-analyzer.properties file. The Util class prepends a prefix to the Java property we pass in as -DconfigFilePath. This prefix resulted in a FileNotFoundException error when attempting to locate the config file inside our Docker environment. This commit fixes the issue by updating the -DconfigFilePath variable in the performance-analyzer-agent script file. This is a stopgap measure. We should strive to refactor the Util class so that it's configurable and working across all supported platforms.
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
============================================
- Coverage 66.33% 66.25% -0.08%
+ Complexity 1795 1792 -3
============================================
Files 270 270
Lines 11990 11990
Branches 952 952
============================================
- Hits 7953 7944 -9
- Misses 3722 3729 +7
- Partials 315 317 +2
Continue to review full report at Codecov.
|
adityaj1107
approved these changes
Jul 21, 2020
sruti1312
approved these changes
Jul 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
We have a class Util.java which we use to look up the location of the
performance-analyzer.properties file. The Util class prepends a prefix
to the Java property we pass in as -DconfigFilePath. This prefix
resulted in a FileNotFoundException error when attempting to locate the
config file inside our Docker environment.
This commit fixes the issue by updating the -DconfigFilePath variable in
the performance-analyzer-agent script file. This is a stopgap measure.
We should strive to refactor the Util class so that it's configurable
and working across all supported platforms.
Tests: Tested manually using enableRca
Code coverage percentage for this patch: N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.