This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Refactor ModifyCacheCapacityAction to follow builder pattern #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sruti1312
added
the
code-refactoring
sidheart
reviewed
Aug 18, 2020
...distro/elasticsearch/performanceanalyzer/decisionmaker/actions/ModifyCacheMaxSizeAction.java
Show resolved
Hide resolved
rguo-aws
approved these changes
Aug 18, 2020
vigyasharma
approved these changes
Aug 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
=========================================
Coverage ? 69.72%
Complexity ? 2238
=========================================
Files ? 301
Lines ? 13481
Branches ? 1116
=========================================
Hits ? 9399
Misses ? 3714
Partials ? 368 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Refactor ModifyCacheCapacityAction to follow builder pattern.
This allows modifying parameters by deciders
Tests:
unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.