This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Operational metrics for 128GB heap decider components #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktkrg
changed the title
sidheart
suggested changes
Oct 19, 2020
| @@ -100,6 +104,7 @@ protected int getFullGcEventsOrDefault(final double defaultValue) { | |||
|
|
|||
| protected double getOldGenUsedOrDefault(final double defaultValue) { | |||
| if (heap_Used == null) { | |||
| StatsCollector.instance().logException(StatExceptionCode.MISCONFIGURED_OLD_GEN_RCA); | |||
There was a problem hiding this comment.
Name this one something different so we can tell it apart from line 81
There was a problem hiding this comment.
I thought one sparse metric was enough. Added them still, just to avoid confusion.
sidheart
approved these changes
Oct 20, 2020
yojs
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
#477
Description of changes:
This PR adds a few operational metrics of interest concerning the 128GB heap decider components. This change also fixes a potential div by 0 bug.
Tests:
Tests for the div by 0 bug is coming in the other PR - for evaluating GC type before running JVM tuning RCAs.
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.