This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Evaluate the 128G RCAs only if CMS is the collector for OldGen #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidheart
suggested changes
Oct 20, 2020
...mazon/opendistro/elasticsearch/performanceanalyzer/rca/store/ElasticSearchAnalysisGraph.java
Outdated
Show resolved
Hide resolved
...mazon/opendistro/elasticsearch/performanceanalyzer/rca/store/ElasticSearchAnalysisGraph.java
Outdated
Show resolved
Hide resolved
...mazon/opendistro/elasticsearch/performanceanalyzer/rca/store/ElasticSearchAnalysisGraph.java
Outdated
Show resolved
Hide resolved
...mazon/opendistro/elasticsearch/performanceanalyzer/rca/store/ElasticSearchAnalysisGraph.java
Outdated
Show resolved
Hide resolved
sidheart
previously approved these changes
Oct 21, 2020
yojs
previously approved these changes
Oct 22, 2020
sidheart
previously approved these changes
Oct 22, 2020
yojs
previously approved these changes
Oct 22, 2020
Addressed checkstyle issue.
yojs
approved these changes
Oct 22, 2020
sidheart
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
Description of changes:
This change adds a new metric node(GC_Type) which tells what collector is used for a memory pool. The metric is used as a gating mechanism to proceed with the evaluation of the HighOldGenOccupancyRca and OldGenReclamationRca.
Tests:
UTs, tested on docker.
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.