This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adjust resizable queue lower bounds to align with the default capacity(200/1000) suggested by ES #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y(200/1000) in ES
vigyasharma
reviewed
Oct 22, 2020
| } | ||
| }, | ||
| // Action Configurations |
There was a problem hiding this comment.
Do we need to add all of these configurations? Wont just changing the default queue lower bounds suffice?
There was a problem hiding this comment.
We don't have to add all configurations in the rca conf but I remember Joydeep once asked me to explicitly add all rca conf into the file so that people who are not familiar with the settings can easily understand and set it
vigyasharma
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
Description of changes:
Our queue related performance experiments indicate that downsizing of the write queue could potentially increase heap pressure when a lot of rejection occurs within a short amount of time. So this PR will adjust the default queue lower bound back to the default queue capacity used by ES. This would at least guarantee that our resizable queue does not introduce extra heap pressure when compared with the vanilla ES.
So now for the write queue, the lower/upper bounds are [200/1000]
and for search queue, the lower/upper bounds are [1000/2000]
Tests:
update UT as well so that the UTs are independent of the actual values being set for queue's lower/upper bounds
If new tests are added, how long do the new ones take to complete
n/a
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.