This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Collator integ test #501
Merged
Collator integ test #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rguo-aws
reviewed
Nov 3, 2020
| } | ||
|
|
||
| @Override | ||
| public boolean checkDbObj(Object object) { |
There was a problem hiding this comment.
Can we read the most recent action list directly from rest endpoint ? Something similar to the OldGenPolicyBaseValidator.java ?
yojs
previously approved these changes
Nov 3, 2020
rguo-aws
approved these changes
Nov 5, 2020
yojs
approved these changes
Nov 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
Description of changes:
This PR adds an integration test for the collator, testing when there are conflicting actions recommended by the deciders.
Tests:
unit tests(excluding flaky ones) + the newly added integ test.
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.