This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adding custom Suppress FindBugs class to make it JDK8 compatible #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidheart
previously approved these changes
Oct 30, 2020
...in/java/com/amazon/opendistro/elasticsearch/performanceanalyzer/util/SuppressFBWarnings.java
Outdated
Show resolved
Hide resolved
sidheart
previously approved these changes
Oct 30, 2020
rguo-aws
reviewed
Oct 30, 2020
rguo-aws
approved these changes
Nov 2, 2020
I have added the getters as well. Keeping the class for any future references. |
ricardolstephen
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #: Since AES is on JDK 8 adding custom classes to Suppress Find-bugs warnings
Description of changes: SupressFBWarnings is present in JDK13. We need this custom class to make it JDK8 compatible.
Tests: Tested locally.
If new tests are added, how long do the new ones take to complete
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.