Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Rename sql-cli wheel to use dashes instead of underscore #1015

Merged
merged 1 commit into from Jan 28, 2021
Merged

Rename sql-cli wheel to use dashes instead of underscore #1015

merged 1 commit into from Jan 28, 2021

Conversation

joshuali925
Copy link
Contributor

Issue #, if available:

Description of changes:
change odfe_sql_cli-1.12.0.0-py3-none-any.whl to odfe-sql-cli-1.12.0.0-py3-none-any.whl when uploading to s3 for infra team's script

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joshuali925 joshuali925 changed the title Rename cli wheel to use dashes instead of underscore Rename sql-cli wheel to use dashes instead of underscore Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #1015 (178d10e) into develop (bf31e1c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1015   +/-   ##
==========================================
  Coverage      99.87%   99.87%           
  Complexity      2406     2406           
==========================================
  Files            234      234           
  Lines           5526     5526           
  Branches         357      357           
==========================================
  Hits            5519     5519           
  Misses             5        5           
  Partials           2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf31e1c...178d10e. Read the comment docs.

@zhongnansu
Copy link
Member

When we upload this artifact to PyPI, what name will we use? Did you try installing from the wheel file? pip install --use-wheel, is there any error?
Ref: pypa/pip#1150 (comment)

@joshuali925
Copy link
Contributor Author

When we upload this artifact to PyPI, what name will we use? Did you try installing from the wheel file? pip install --use-wheel, is there any error?

I think --use-wheel is deprecated. I've tried pip install odfe-sql-cli-1.12.0.0-py3-none-any.whl and did some sanity tests, didn't see errors. Also this doesn't affect release as we won't be pushing to PyPI from S3. When we push it will still be odfe_sql_cli-1.12.0.0-py3-none-any.whl locally. This is only for infra team's scripts to work.

@joshuali925 joshuali925 merged commit 959458b into opendistro-for-elasticsearch:develop Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants