Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Disable access to the field keyword in the new SQL engine #1025

Merged
merged 3 commits into from Feb 3, 2021

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Jan 30, 2021

*Issue #, if available: #1019

Description of changes:

  1. Disable access to the field keyword in the new SQL engine.
  2. Add as a breaking change for new SQL engine release. https://github.com/penghuo/sql/blob/issue-1019/docs/dev/NewSQLEngine.md#312-syntax-and-semantic

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo self-assigned this Jan 30, 2021
@penghuo penghuo added the Breaking Changes Breaking Changes that will impact clients label Jan 30, 2021
@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #1025 (f163a20) into develop (1dbf244) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1025      +/-   ##
=============================================
- Coverage      99.87%   99.87%   -0.01%     
+ Complexity      2416     2415       -1     
=============================================
  Files            234      234              
  Lines           5547     5544       -3     
  Branches         359      358       -1     
=============================================
- Hits            5540     5537       -3     
  Misses             5        5              
  Partials           2        2              
Impacted Files Coverage Δ Complexity Δ
...search/sql/elasticsearch/mapping/IndexMapping.java 100.00% <ø> (ø) 13.00 <0.00> (-2.00)
.../sql/elasticsearch/storage/ElasticsearchIndex.java 100.00% <100.00%> (ø) 4.00 <2.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbf244...f163a20. Read the comment docs.

Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit d7cfad6 into opendistro-for-elasticsearch:develop Feb 3, 2021
@penghuo penghuo deleted the issue-1019 branch February 3, 2021 05:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Changes Breaking Changes that will impact clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants