This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Function support for IS/IS NOT in WHERE clause #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anirudha
reviewed
Jan 13, 2020
src/main/java/com/amazon/opendistroforelasticsearch/sql/parser/WhereParser.java
Show resolved
Hide resolved
abbashus
reviewed
Jan 13, 2020
src/test/java/com/amazon/opendistroforelasticsearch/sql/esintgtest/SQLFunctionsIT.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Jan 13, 2020
| @Test | ||
| public void functionAbsInWhereClauseWithIsNullTest() { | ||
| JSONObject response = executeJdbcRequest( | ||
| "SELECT age FROM " + TEST_INDEX_ACCOUNT + " WHERE (ABS(balance) IS NULL)" |
There was a problem hiding this comment.
So all your IT use TEST_INDEX_ACCOUNT index for testing, I wonder is there any document in this index missing balance or firstname field? Because I recall the painless scripts we generate are unable to handle missing field (#308), I assume your IT actually doesn't cover the typical use of IS NULL or IS NOT NULL.
There was a problem hiding this comment.
Good point- I'll look for/create an index with some missing field values
There was a problem hiding this comment.
One suggestion, instead of create new index, could we consider using the existing index. I think there are already 10+ different indices in place.
penghuo
reviewed
Jan 23, 2020
Comment on lines
+346
to
+350
| // Assert.assertThat( | ||
| // response.getJSONArray("datarows") | ||
| // .getJSONArray(i).get(0), | ||
| // equalTo(expectedOutput[i])); | ||
| System.out.println(response.getJSONArray("datarows").getJSONArray(i).getString(0)); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#341
Description of changes:
Adding support for usage of functions with the IS/IS NOT keywords in the WHERE clause.
Example query:
SELECT dayOfWeek FROM kibana_sample_data_flights WHERE ABS(balance) IS NOT NULLBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.