This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
ODBC: Report error from Excel when executing an invalid query #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- save error type and details on connection errors - start checking error type when reporting error (first: query syntax)
jduo
reviewed
Jul 23, 2020
sql-odbc/src/odfesqlodbc/odbcapi.c
Outdated
|
|
||
| MYLOG(ES_TRACE, "entering\n"); | ||
|
|
||
| if (EnvironmentHandle) { |
There was a problem hiding this comment.
You should check this Statement, connection, then environment rather than the other way around. The most recently constructed handle gets priority.
There was a problem hiding this comment.
Reversed order of handle checks
jduo
reviewed
Jul 23, 2020
| if (Sqlstate) | ||
| utf8_to_ucs2(qstr_ansi, -1, Sqlstate, 6); | ||
| if (mtxt && tlen <= BufferLength) { | ||
| SQLULEN ulen = utf8_to_ucs2_lf(mtxt, tlen, FALSE, MessageText, |
There was a problem hiding this comment.
SQLCHAR inputs aren't guaranteed to be UTF-8. On Windows it depends on the OS codepage for example (usually codepage CP1252), though on Windows the DM does the conversion for you. This should likely be a separate issue to fix.
There was a problem hiding this comment.
👍 Will log another issue for this
rupal-bq
approved these changes
Jul 24, 2020
jduo
approved these changes
Jul 24, 2020
jduo
approved these changes
Jul 24, 2020
dai-chen
approved these changes
Jul 25, 2020
chloe-zh
approved these changes
Jul 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #601
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.