Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[UI] Separate SQL and PPL pages #761

Merged
merged 5 commits into from Sep 30, 2020
Merged

[UI] Separate SQL and PPL pages #761

merged 5 commits into from Sep 30, 2020

Conversation

chloe-zh
Copy link
Member

Issue #, if available:

Description of changes:

  • Separate to SQL and PPL pages that can be switched by the SQL/PPL toggle
  • Added PPL Documentation link popout
  • Corrected the download routes for PPL results
  • Added modal with error message when download ppl results of json/csv/raw formats since these formats are unsupported yet

Video Walkthrough

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chloe-zh chloe-zh self-assigned this Sep 29, 2020
joshuali925
joshuali925 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to have separate SQLPage and PPLPage components? Right now they seem to be the same component with different prop/state variable names

workbench/public/components/Main/main.tsx Show resolved Hide resolved
workbench/public/components/QueryResults/QueryResultsBody.tsx Outdated Show resolved Hide resolved
@chloe-zh
Copy link
Member Author

Why is it necessary to have separate SQLPage and PPLPage components? Right now they seem to be the same component with different prop/state variable names

It's because we will have different components in SQL and PPL pages in our latest ux design, but not refracted in this PR yet. We will elaborate the details later.

@joshuali925
Copy link
Contributor

It's because we will have different components in SQL and PPL pages in our latest ux design, but not refracted in this PR yet. We will elaborate the details later.

Got it, thanks!

@chloe-zh chloe-zh merged commit 87e7e02 into opendistro-for-elasticsearch:develop Sep 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anirudha anirudha anirudha approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

Assignees

@chloe-zh chloe-zh

Labels
Workbench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chloe-zh @joshuali925 @anirudha