This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Revert Error Messages for Run/Explain #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #889 +/- ##
==========================================
Coverage 99.85% 99.85%
Complexity 2132 2132
==========================================
Files 215 215
Lines 4774 4774
Branches 313 313
==========================================
Hits 4767 4767
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
joshuali925
approved these changes
Dec 4, 2020
chloe-zh
approved these changes
Dec 4, 2020
joshuali925
pushed a commit
that referenced
this pull request
Dec 7, 2020
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
After discussion with @anirudha , revert
Runerror message to JSON format to avoid necessity for any front-end changes upon modification of back-end response. Also simplifiedExplainerror to simplyThis query is not explainable, as the backend response is not helpful to the user at all (unable to parse/serialize body).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.