This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix improper handling of the table expression #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsen-es
reviewed
Jun 20, 2019
...n/java/com/amazon/opendistroforelasticsearch/sql/rewriter/matchtoterm/TermFieldRewriter.java
Show resolved
Hide resolved
arsen-es
reviewed
Jun 20, 2019
...n/java/com/amazon/opendistroforelasticsearch/sql/rewriter/matchtoterm/TermFieldRewriter.java
Outdated
Show resolved
Hide resolved
arsen-es
reviewed
Jun 20, 2019
src/test/java/com/amazon/opendistroforelasticsearch/sql/unittest/bugs/BuggedQueries.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Jun 20, 2019
src/test/java/com/amazon/opendistroforelasticsearch/sql/unittest/bugs/BuggedQueries.java
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/opendistroforelasticsearch/sql/unittest/bugs/BuggedQueries.java
Outdated
Show resolved
Hide resolved
abbashus
reviewed
Jun 20, 2019
...n/java/com/amazon/opendistroforelasticsearch/sql/rewriter/matchtoterm/TermFieldRewriter.java
Outdated
Show resolved
Hide resolved
arsen-es
approved these changes
Jun 20, 2019
dai-chen
approved these changes
Jun 20, 2019
|
This PR was to fix issue #92 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The wrong query, such as "select * from abc like 'zzz'" was throwing server error instead of ParserError, fixing that.
Introduced variables and simplified some very long casts for easier debugging
Testing: unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.