This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix key "id" in result table issue of the workbench #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #890 +/- ##
==========================================
Coverage 99.85% 99.85%
Complexity 2146 2146
==========================================
Files 216 216
Lines 4833 4833
Branches 318 318
==========================================
Hits 4826 4826
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
penghuo
approved these changes
Dec 4, 2020
davidcui1225
reviewed
Dec 4, 2020
davidcui1225
approved these changes
Dec 4, 2020
joshuali925
added a commit
that referenced
this pull request
Dec 7, 2020
* removed key "id" from result table * removed cache files from PR * remove unnecessary lines * fixed search bar * update * update * update * update * update Co-authored-by: Joshua <joshuali925@gmail.com>
chloe-zh
added a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
…lasticsearch#890) * removed key "id" from result table * removed cache files from PR * remove unnecessary lines * fixed search bar * update * update * update * update * update Co-authored-by: Joshua <joshuali925@gmail.com>
chloe-zh
added a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
…lasticsearch#890) * removed key "id" from result table * removed cache files from PR * remove unnecessary lines * fixed search bar * update * update * update * update * update Co-authored-by: Joshua <joshuali925@gmail.com>
chloe-zh
added a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
…lasticsearch#890) * removed key "id" from result table * removed cache files from PR * remove unnecessary lines * fixed search bar * update * update * update * update * update Co-authored-by: Joshua <joshuali925@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#875
Description of changes:
DataRowstruct with propertiesrowIdanddataas one data row, replaced the dictionary type withDataRowin result setgetQueryResultsForTableto more readable and understandable onesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.