This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Disable sorting on workbench #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcui1225
reviewed
Dec 8, 2020
| @@ -104,7 +104,7 @@ describe("<QueryResults with data/> spec", () => { | |||
| await fireEvent.click(getAllByRole('tab')[5]); | |||
|
|
|||
| // It tests sorting | |||
| await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]); | |||
| // await fireEvent.click(getAllByTestId('tableHeaderSortButton')[1]); | |||
There was a problem hiding this comment.
np: here and other places where lines are commented out, can we add TODO comments?
davidcui1225
approved these changes
Dec 8, 2020
Codecov Report
@@ Coverage Diff @@
## develop #900 +/- ##
==========================================
Coverage 99.85% 99.85%
Complexity 2148 2148
==========================================
Files 216 216
Lines 4850 4850
Branches 320 320
==========================================
Hits 4843 4843
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
chloe-zh
approved these changes
Dec 8, 2020
joshuali925
added a commit
that referenced
this pull request
Dec 9, 2020
* Disable sorting on workbench * Address comments
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
* Disable sorting on workbench * Address comments
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
* Disable sorting on workbench * Address comments
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
* Disable sorting on workbench * Address comments
chloe-zh
pushed a commit
to chloe-zh/sql
that referenced
this pull request
Dec 15, 2020
* Disable sorting on workbench * Address comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Workbench doesn't sort correctly after moving to new platform and Kibana 7.10.0. To fix we will need to refactor codebase. This PR will disable sorting in case we don't have time to fix it for this release.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.