ECDSA P-521 support in SoftHSMv2

[qbert2k]

I was testing SoftHSMv2 through PKCS#11 and I found it is working fine for ECDSA algorithms ES256 and ES384 but it is not working for the algorithm ES512 (curve P-521)

Curve	Curve Alias	Curve OID	Succeed
P-256	secp256r1	1.2.840.10045.3.1.7	Yes
P-384	secp384r1	1.3.132.0.34	Yes
P-521	secp521r1	1.3.132.0.35	No

Are there any plans for ECDSA with EC P-521 support?

[bellgrim]

I have not tested with P-521, but both Botan and OpenSSL should support it and thus also SoftHSM. Do you have more details from your tests? E.g error logs and library versions.

[justinburke]

I've run into this issue as well. The following diff adds a failing test for secp521r1:
justinburke@48fd634

[matthauck]

Running into this as well. Would be great to add support for secp521r1

[bellgrim]

The problem was in the OpenSSL crypto backend for SoftHSM. It could not handle EC points larger than 127 bytes when converting to ASN1 format. Fixed in #231

[matthauck]

I think this still an issue in the import key logic in softhsm-util. Agreed that this is not the best practice workflow, but the code is there and should probably either be removed or fixed. Reopen this issue or open another one?

[bellgrim]

The issue about ECDSA P-521 via PKCS#11 has been resolved.

Fixing ECDSA P-521 in softhsm2-util would be a new, but similar, issue. Could you create one?

My guess is that we have to fix this:
https://github.com/opendnssec/SoftHSMv2/blob/develop/src/bin/util/softhsm2-util-ossl.cpp#L657

[matthauck]

Filed #262!

[bellgrim]

Thanks!