Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #190: Support for OpenSSL 1.1.0 #234

Merged
merged 5 commits into from Sep 30, 2016
Merged

Conversation

bellgrim
Copy link
Contributor

No description provided.

@bellgrim
Copy link
Contributor Author

#build

@jariq
Copy link
Contributor

jariq commented Sep 11, 2016

@bellgrim I am testing this patch on Windows and would like to add some changes (mostly related to win32 build process). However I am not sure whether to open PR against bellgrim:issue190 branch or wait until this gets merged into opendnssec:develop. Any suggestions?

@bellgrim
Copy link
Contributor Author

Thanks for patching the Windows build. Forgot to update the Windows configure script and build files.

If it works I could merge the changes into my branch.

@jariq
Copy link
Contributor

jariq commented Sep 25, 2016

You have fixed all the issues that bothered me before I even managed to put a PR together :) However I am not sure about the build notes because I was using slightly different command to configure OpenSSL:

perl Configure VC-WIN32 --prefix=C:\build\bin\openssl-1.1.0a-x86 --openssldir=C:\build\bin\openssl-1.1.0a-x86\ssl no-shared

Individual options:

  • openssldir - without this option I had to run command line in administrator mode because by default those files got installed into Program Files folder
  • no-shared - this option actually enables static build

BTW I am not sure whether enable-static-engine option is still valid in 1.1.0. If I remember correctly the build was successful regardless of its presence. I'll try to investigate this a little more.

@bellgrim
Copy link
Contributor Author

bellgrim commented Sep 30, 2016

Thanks, updated the build notes according to your suggestions.

@bellgrim bellgrim merged commit c4ef48d into opendnssec:develop Sep 30, 2016
@bellgrim bellgrim deleted the issue190 branch September 30, 2016 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants