Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compilation on macOS 10.15.4, Xcode 11.4 #537

Merged
merged 1 commit into from Mar 25, 2020
Merged

Allow compilation on macOS 10.15.4, Xcode 11.4 #537

merged 1 commit into from Mar 25, 2020

Conversation

iay
Copy link
Contributor

@iay iay commented Mar 25, 2020

Resolves #535.

@rijswijk
Copy link
Contributor

Looks good to me, I don't think this needs a review (@halderen what do you think?), will merge after the CI tests are complete.

@iay
Copy link
Contributor Author

iay commented Mar 25, 2020

CI jobs appear to be failing with many instances of:

c:\projects\softhsmv2\src\lib\common\log.h(40): fatal error C1083:
    Cannot open include file: 'syslog.h': No such file or directory
    [C:\projects\softhsmv2\src\lib\common\softhsm_common.vcxproj]

I don't think those have been introduced by this PR.

@halderen halderen merged commit e4c954e into opendnssec:develop Mar 25, 2020
@iay iay deleted the catalina-compile branch March 26, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiling errors out on mac os
3 participants
@iay @rijswijk @halderen