Merge pull request #162 from yschaeff/short-reply-crash

Signer hits assertion when receiving a short reply.
opendnssec · Aug 7, 2015 · b3820a9 · b3820a9
2 parents be97ccb + 2decb9e
commit b3820a9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/signer/src/wire/notify.c b/signer/src/wire/notify.c
@@ -282,7 +282,8 @@ notify_handle_reply(notify_type* notify)
     ods_log_assert(xfrhandler);
     ods_log_assert(zone);
     ods_log_assert(zone->name);
-    if ((buffer_pkt_opcode(xfrhandler->packet) != LDNS_PACKET_NOTIFY) ||
+    if (xfrhandler->packet->limit < 3 ||
+        (buffer_pkt_opcode(xfrhandler->packet) != LDNS_PACKET_NOTIFY) ||
         (buffer_pkt_qr(xfrhandler->packet) == 0)) {
         ods_log_error("[%s] zone %s received bad notify reply opcode/qr from %s",
             notify_str, zone->name, notify->secondary->address);