SUPPORT-291: Wrong inception time in keyData after migration #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUPPORT-291, https://issues.opendnssec.org/browse/SUPPORT-291 During migration from 1.4 MySQL database to 2.1.x, a conversion script with associated SQL in /usr/share/opendnssec/migration/1.4-2.0_db_convert/mysql_convert.sql creates new db structure TABLE keyData. The table has field 'inception', which in 1.4 parlance is 'generate', i.e. the time when the key was born into existence. The migration script incorrectly uses 'dnsseckeys.publish' and not 'keypairs.generate' when populating TABLE keyData, so a time-wise logical impossibility ensues. This is a problem (at least) when ZSKs autoroll. New key is taken from HSM and becomes 'ready' and old key becomes 'retire'. However, nothing happens after that and the zone ends up with both keys, and both keys are used for signing, i.e. double signature. DNS will not break, but it's an annoyance and I believe it doubles the reply size. The situation can be resolved doing manual 'sudo -u ods ods-enforcer key rollover -t ZSK -p ...' or similar, but it is annoying nonetheless. This patch fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUPPORT-291, https://issues.opendnssec.org/browse/SUPPORT-291
During migration from 1.4 MySQL database to 2.1.x, a conversion script with associated SQL in /usr/share/opendnssec/migration/1.4-2.0_db_convert/mysql_convert.sql creates new db structure TABLE keyData.
The table has field 'inception', which in 1.4 parlance is 'generate', i.e. the time when the key was born into existence.
The migration script incorrectly uses 'dnsseckeys.publish' and not 'keypairs.generate' when populating TABLE keyData, so a time-wise logical impossibility ensues.
This is a problem (at least) when ZSKs autoroll. New key is taken from HSM and becomes 'ready' and old key becomes 'retire'. However, nothing happens after that and the zone ends up with both keys, and both keys are used for signing, i.e. double signature. DNS will not break, but it's an annoyance and I believe it doubles the reply size. The situation can possibly be resolved doing manual 'sudo -u ods ods-enforcer key rollover -t ZSK -p ...' or similar, but it is annoying nonetheless.
This patch fixes the issue.