implicit function declaration fixes #854
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utilities.h header file is necessary for clamp function, otherwise compilation fails with implicit function declarations error with moder compilers. This is baiscally backport of commit f41dd60 ("Compile warning. clamp implicitely defined.") Bug: https://bugs.gentoo.org/871294
The time.h header file is needed for strptime function, otherwise modern compilers fail with implicit function declaration error. Moreover, getopt.h needs to be included after config.h otherwise global configuration will not be respected. This can affect time.h as they both include features.h. Bug: https://bugs.gentoo.org/879727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two implicit function declaration issues which are problematic with modern compilers like gcc-14. The fix is simple, it is necessary to include header files. See commit messages for more info.