Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move js from footer to header in tweeter template #227

Open
stephenlawrence opened this issue Oct 9, 2015 · 3 comments
Open

Move js from footer to header in tweeter template #227

stephenlawrence opened this issue Oct 9, 2015 · 3 comments

Comments

@stephenlawrence
Copy link
Member

No description provided.

@stephenlawrence stephenlawrence added this to the 1.3.5 milestone Oct 9, 2015
@apmuthu
Copy link

apmuthu commented Oct 9, 2015

This was done to keep all include files at the head and be used anywhere. This is a single commit and can be cherry picked.
apmuthu@d3188b9

@FavioGalvis
Copy link

Include files (boostrap,js and other includes) (by standard) must be loaded on the footer, to increase the load speed of the pages.

@apmuthu
Copy link

apmuthu commented Oct 10, 2015

The idea was to enable suppressing the footer itself to conserve screen real estate. Furthermore, this application needs to render the page only after all js is loaded since we do not want any security breach by it's absence if it is possible.

In regular CMSes and other large applications, what you say is very useful but not here in teeny weeny ODM. Hence I'd like to keep it this way in my fork.

Thanks for the input though.

@stephenlawrence stephenlawrence removed this from the 1.3.5 milestone Jan 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants