Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it use the mirror by default, and add necessary headers #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dan-hipschman
Copy link

@dan-hipschman dan-hipschman commented Apr 29, 2024

Context

This branch has image tag mirror-1.

See this slack thread for why the headers are needed: https://opendoor.slack.com/archives/C066PGLK77B/p1714072860609209

This also makes the mirror the default, since we plan to use it everywhere, it'll save typing in the pipelines.

Test Plan

Tested this out on one of our pipelines and it works.

Mitigation

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to external documentation if necessary (READMEs, Confluence, etc.)
  • I have checked that other PRs this PR depends on have already been deployed.
  • I can confirm that if this PR introduces a DB schema change, I have read and followed all the steps outlined in the Data Contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant