Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent chain constructors #36

Closed
andrewvyrros opened this issue Mar 12, 2021 · 2 comments · Fixed by #49
Closed

Inconsistent chain constructors #36

andrewvyrros opened this issue Mar 12, 2021 · 2 comments · Fixed by #49
Assignees
@andrewvyrros
Labels
Effort 1 - Small ☕ Used for estimation
Projects
OpenDP Development
Milestone
0.1.0-M2

Comments

@andrewvyrros
Copy link
Member

In the changes for #30, we messed up something, and now test.py is crashing:

/usr/local/bin/python3.8 /Users/av/Projects/opendp/python/test.py
Initialized OpenDP Library
"hello, world!"

Process finished with exit code 139 (interrupted by signal 11: SIGSEGV)

The crash happens at line 38:

    everything = odp.core.make_chain_tt(composition, parse_dataframe)
@andrewvyrros andrewvyrros added this to Needs Discussion in OpenDP Development via automation Mar 12, 2021
@andrewvyrros andrewvyrros moved this from Needs Discussion to Ready for Development in OpenDP Development Mar 16, 2021
@andrewvyrros
Copy link
Member Author

Looks like this is because we somehow ended up with multiple versions of the chain constructors, the bare functions make_chain_xx() and the structs ChainXX, and we're using them inconsistently from FFI.

@andrewvyrros andrewvyrros self-assigned this Mar 16, 2021
@andrewvyrros andrewvyrros changed the title Crash in test.py Inconsistent chain constructors Mar 16, 2021
@andrewvyrros
Copy link
Member Author

Also a bug test.py, at the end we're calling make_chain_tt() instead of make_chain_mt().

This was referenced Mar 17, 2021
Closed
Merged
OpenDP Development automation moved this from Ready for Development to Done Mar 17, 2021
@andrewvyrros andrewvyrros added the Effort 1 - Small ☕ Used for estimation label Mar 19, 2021
@andrewvyrros andrewvyrros added this to the 0.1.0-M2 milestone Jun 16, 2021
@andrewvyrros andrewvyrros removed the v0.1 label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewvyrros andrewvyrros

Labels
Effort 1 - Small ☕ Used for estimation
Projects
OpenDP Library Development
Archived in project
OpenDP Development
Done
Milestone
0.1.0-M2
Development

Successfully merging a pull request may close this issue.

Inconsistent chain constructors opendp/opendp
1 participant
@andrewvyrros