New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton based action recognition #50
Conversation
engine.target and engine.data are modified.
feeder.py is also updated to generate bone and motion data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems fine, nice work! One comment: Please check if separate model is saved into a separate folder (e.g., if a model if named "test_model", then a folder with name "test_model" should be created and all relevant files should exist within this folder).
Failing again even when I disable all the other tests. I think it might be a memory issue on this server, not sufficient RAM memory, or garbage collector's inconsistency. |
Please resolve the conflicts and update to master to check if the new testing system is fixing the test errors. |
@stefaniapedrazzi when I update the |
It would be very helpful to also see the log you receive when the push is rejected. |
I think that the file can be edited by anyone (e.g., Lukas is not a codeowner and he edited this file). Can you provide more details regarding the reject? Please also check that you editing the file on your branch and not in the master branch. |
@stefaniapedrazzi , @passalis: Problem is solved. It was related to my personal access token. |
Could you please also update the documentation index by adding your newly added documentation page? Otherwise now everything is fine for me. |
@stefaniapedrazzi Index.md is updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This PR adds two learners (which train and evaluate a baseline model and three proposed models) for skeleton-based human action recognition.
A new data type named
SkeletonSequence
is added to theengine.data.py
and a new target class namedActionCategory
is added toengine.target.py
.The learners' implementation follows the provided template and sufficient tests are provided for all the functions which will be directly called by the user including,
fit()
,eval()
,infer()
,save()
,load()
,optimize()
,multi_stream_eval()
,network_builder()
.