Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton based action recognition #50

Merged
merged 108 commits into from Sep 22, 2021
Merged

Conversation

negarhdr
Copy link
Collaborator

@negarhdr negarhdr commented Apr 3, 2021

This PR adds two learners (which train and evaluate a baseline model and three proposed models) for skeleton-based human action recognition.

  • A new data type named SkeletonSequence is added to the engine.data.py and a new target class named ActionCategory is added to engine.target.py.

  • The learners' implementation follows the provided template and sufficient tests are provided for all the functions which will be directly called by the user including, fit(), eval(), infer(), save(), load(), optimize(), multi_stream_eval(), network_builder().

@negarhdr negarhdr added the enhancement New feature or request label Apr 3, 2021
Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems fine, nice work! One comment: Please check if separate model is saved into a separate folder (e.g., if a model if named "test_model", then a folder with name "test_model" should be created and all relevant files should exist within this folder).

@negarhdr
Copy link
Collaborator Author

Failing again even when I disable all the other tests. I think it might be a memory issue on this server, not sufficient RAM memory, or garbage collector's inconsistency.

@stefaniapedrazzi
Copy link
Collaborator

stefaniapedrazzi commented Sep 8, 2021

Please resolve the conflicts and update to master to check if the new testing system is fixing the test errors.
You also have to add the test skeleton_based_action_recognition in this list:
https://github.com/tasostefas/opendr_internal/blob/7496b7356fd492b0fb9c9ba2e81111e95aac8140/.github/workflows/tests_sources.yml#L66

@negarhdr
Copy link
Collaborator Author

Please resolve the conflicts and update to master to check if the new testing system is fixing the test errors.
You also have to add the test skeleton_based_action_recognition in this list:
https://github.com/tasostefas/opendr_internal/blob/7496b7356fd492b0fb9c9ba2e81111e95aac8140/.github/workflows/tests_sources.yml#L66

@stefaniapedrazzi when I update the opendr_internal/.github/workflows/tests_sources.yml file, the Push is rejected!
Isn't it the case that this file can only be modified by code owners?

@stefaniapedrazzi
Copy link
Collaborator

stefaniapedrazzi commented Sep 13, 2021

@stefaniapedrazzi when I update the opendr_internal/.github/workflows/tests_sources.yml file, the Push is rejected!
Isn't it the case that this file can only be modified by code owners?

It would be very helpful to also see the log you receive when the push is rejected.
I don't think that only code owners can modify it, but I'm not an administrator of this repository so I cannot check the settings.
How do you perform the git actions? Directly from a terminal or using some applications?
If you are using an application, could you please try directly from a terminal?

@passalis
Copy link
Collaborator

I think that the file can be edited by anyone (e.g., Lukas is not a codeowner and he edited this file). Can you provide more details regarding the reject? Please also check that you editing the file on your branch and not in the master branch.

@negarhdr
Copy link
Collaborator Author

negarhdr commented Sep 15, 2021

@stefaniapedrazzi , @passalis: Problem is solved. It was related to my personal access token.
All the tests are passed and the branch is ready to be merged.

@stefaniapedrazzi
Copy link
Collaborator

Could you please also update the documentation index by adding your newly added documentation page?
https://github.com/tasostefas/opendr_internal/blob/master/docs/reference/index.md

Otherwise now everything is fine for me.

@negarhdr
Copy link
Collaborator Author

Could you please also update the documentation index by adding your newly added documentation page?
https://github.com/tasostefas/opendr_internal/blob/master/docs/reference/index.md

Otherwise now everything is fine for me.

@stefaniapedrazzi Index.md is updated.

Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@negarhdr negarhdr merged commit 4ea8a86 into master Sep 22, 2021
@stefaniapedrazzi stefaniapedrazzi deleted the skeleton_based_action_recognition branch June 6, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks test tools Test the toolkit methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants