Object detection 2d yolov5 #360

vivinousi · 2022-11-28T16:22:20Z

This PR introduces YOLOv5 as an inference-only addition to the toolkit

…velop

…r-eu/opendr into object-detection-2d-yolov5

passalis

Thank you! This seems overall fine for me as an inference-only tool. I have only two minor comments.

docs/reference/object-detection-2d-yolov5.md

src/opendr/perception/object_detection_2d/yolov5/yolov5_learner.py

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

… the model every time

… object-detection-2d-yolov5

ad-daniel

Very good thank you.
The documentation page should also be referenced in the index.md file, a changelog entry should be added, and a handful of details

docs/reference/object-detection-2d-yolov5.md

tsampazk

Thank you @vivinousi, the new tool looks good. I have only some minor comments.

docs/reference/object-detection-2d-yolov5.md

projects/opendr_ws/src/perception/README.md

projects/python/perception/object_detection_2d/yolov5/inference_tutorial.ipynb

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

…e_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

vivinousi · 2022-11-30T10:41:55Z

Very good thank you. The documentation page should also be referenced in the index.md file, a changelog entry should be added, and a handful of details

Thank you Daniel, I added an entry in the index.md file as well as in the changelog, although I added today's date there which might need to be updated, in ab30d52

ad-daniel

All good for my side, thanks!

tsampazk

Thank you!

vivinousi added 6 commits August 17, 2022 16:37

DetectionDataset evaluation fix for empty detections

de0e88d

Merge branch 'develop' of https://github.com/opendr-eu/opendr into de…

688ece8

…velop

Merge branch 'develop' of https://github.com/opendr-eu/opendr into de…

7a350ab

…velop

yolov5 initial commit

603ea6a

yolov5 learner cleanup

3dcf2ec

Merge branch 'object-detection-2d-yolov5' of https://github.com/opend…

e614f82

…r-eu/opendr into object-detection-2d-yolov5

vivinousi requested review from passalis, omichel, ad-daniel and stefaniapedrazzi as code owners November 28, 2022 16:22

tsampazk self-requested a review November 28, 2022 16:27

ad-daniel added test sources Run style checks test tools Test the toolkit methods labels Nov 28, 2022

vivinousi added the enhancement New feature or request label Nov 28, 2022

vivinousi added 2 commits November 28, 2022 18:33

yolov5 documentation fix

b8f8e19

yolov5 demo fix

b66516b

passalis reviewed Nov 29, 2022

View reviewed changes

docs/reference/object-detection-2d-yolov5.md Outdated Show resolved Hide resolved

src/opendr/perception/object_detection_2d/yolov5/yolov5_learner.py Outdated Show resolved Hide resolved

vivinousi and others added 5 commits November 29, 2022 09:33

Update docs/reference/object-detection-2d-yolov5.md

2e0e580

Co-authored-by: Nikolaos Passalis <passalis@users.noreply.github.com>

added force_reload as a parameter for the user to avoid redownloading…

1880029

… the model every time

added image size as inference parameter

fb6a7ce

ROS1 docs update

371507b

pep8 fixes

a6ae879

ad-daniel assigned vivinousi Nov 29, 2022

tsampazk and others added 4 commits November 29, 2022 13:40

Merge branch 'develop' into object-detection-2d-yolov5

68e1ade

pep8 fixes

b754a3a

Merge remote-tracking branch 'origin/object-detection-2d-yolov5' into…

1ead494

… object-detection-2d-yolov5

added tool to .yml files for testing

e8ce019

vivinousi marked this pull request as draft November 29, 2022 13:36

vivinousi and others added 2 commits November 29, 2022 16:38

fix dependencies

86526bf

Minor improvements on inference demo

0b79c5f

tsampazk added 2 commits November 29, 2022 17:55

Simple YOLOv5 webcam demo

d500d84

Minor fix for deprecation warning

54cd78a

tsampazk mentioned this pull request Nov 29, 2022

ROS2 workspace and example nodes #256

Merged

24 tasks

vivinousi marked this pull request as ready for review November 29, 2022 17:13

ad-daniel requested changes Nov 30, 2022

View reviewed changes

tsampazk added 2 commits November 30, 2022 11:48

Added 'opendr' in node name

270a6b6

Added webcam demo reference in yolov5 readme list

acadb92

tsampazk reviewed Nov 30, 2022

View reviewed changes

vivinousi and others added 9 commits November 30, 2022 12:30

Update docs/reference/object-detection-2d-yolov5.md

da7405f

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Update docs/reference/object-detection-2d-yolov5.md

7f750ab

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Update docs/reference/object-detection-2d-yolov5.md

14d6eb2

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Update docs/reference/object-detection-2d-yolov5.md

7b1389c

Co-authored-by: ad-daniel <44834743+ad-daniel@users.noreply.github.com>

Update docs/reference/object-detection-2d-yolov5.md

dfb08d7

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Update docs/reference/object-detection-2d-yolov5.md

76d004a

Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Update projects/python/perception/object_detection_2d/yolov5/inferenc…

2394ea3

…e_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

Update projects/python/perception/object_detection_2d/yolov5/inferenc…

ce6e3eb

…e_tutorial.ipynb Co-authored-by: Kostas Tsampazis <27914645+tsampazk@users.noreply.github.com>

index + changelog + notebook fixes

ab30d52

Changelog fix

cd24959

ad-daniel approved these changes Nov 30, 2022

View reviewed changes

tsampazk approved these changes Nov 30, 2022

View reviewed changes

vivinousi merged commit fad5d29 into develop Nov 30, 2022

vivinousi deleted the object-detection-2d-yolov5 branch November 30, 2022 12:12

ad-daniel mentioned this pull request Nov 30, 2022

Tx2 install #195

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Object detection 2d yolov5 #360

Object detection 2d yolov5 #360

vivinousi commented Nov 28, 2022

passalis left a comment

ad-daniel left a comment

tsampazk left a comment

vivinousi commented Nov 30, 2022

ad-daniel left a comment •

edited

tsampazk left a comment

Object detection 2d yolov5 #360

Object detection 2d yolov5 #360

Conversation

vivinousi commented Nov 28, 2022

passalis left a comment

Choose a reason for hiding this comment

ad-daniel left a comment

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

vivinousi commented Nov 30, 2022

ad-daniel left a comment • edited

Choose a reason for hiding this comment

tsampazk left a comment

Choose a reason for hiding this comment

ad-daniel left a comment •

edited